feat(grpc): add exit_idle to LbPolicy trait #2332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Jul 8, 2025
|
|
||
| fn exit_idle(&mut self, channel_controller: &mut dyn ChannelController) { | ||
| todo!() | ||
| // TODO(cjzhao): add exit idle logic once everything has been merged in |
There was a problem hiding this comment.
Note that the todo! macro accepts a string that is printed when it is encountered, which might be nicer. Just todo!("implement exit_idle") seems fine.
There was a problem hiding this comment.
You can delete the comment here in that case.
Comment on lines
147
to
148
| /// Called by policy when it needs to exit the idle state and start connecting | ||
| /// to subchannels. |
There was a problem hiding this comment.
This is a method on the policy, so it is called by the channel when it wants the lb policy to connect.
dfawley
reviewed
Jul 8, 2025
| todo!(); | ||
| } | ||
|
|
||
| fn exit_idle(&mut self, channel_controller: &mut dyn ChannelController) { |
There was a problem hiding this comment.
Please fix the CI error that happened for this line.
dfawley
approved these changes
Aug 5, 2025
|
|
||
| fn exit_idle(&mut self, channel_controller: &mut dyn ChannelController) { | ||
| todo!() | ||
| // TODO(cjzhao): add exit idle logic once everything has been merged in |
There was a problem hiding this comment.
You can delete the comment here in that case.
| /// WorkScheduler's request_work method. | ||
| fn work(&mut self, channel_controller: &mut dyn ChannelController); | ||
|
|
||
| /// Called by the channel when a LbPolicy goes Idle and the channel |
There was a problem hiding this comment.
Nit:
Suggested change
| /// Called by the channel when a LbPolicy goes Idle and the channel | |
| /// Called by the channel when an LbPolicy goes idle and the channel |
cjqzhao
force-pushed
the
exitidletrait
branch
2 times, most recently
from
7a08a93 to
77588f0
Compare
dfawley
approved these changes
Aug 7, 2025
dfawley
changed the title
cjqzhao
force-pushed
the
exitidletrait
branch
2 times, most recently
from
c9cc1e6 to
b0aa1ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add exit_idle to LbPolicy Trait and Child Manager.
@dfawley @easwars